| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | [PATCH] COPY command's data format option allows only lowercase csv, text or binary |
| Date: | 2020-06-24 09:50:34 |
| Message-ID: | CALj2ACXJEXnh8DogA242kdX6ChiVmq3-P5m20ouMD4XMdWDScA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
COPY command's FORMAT option allows only all lowercase csv, text or
binary, this is true because strcmp is being used while parsing these
values.
It would be nice if the uppercase or combination of lower and upper
case format options such as CSV, TEXT, BINARY, Csv, Text, Binary so
on. is also allowed.
To achieve this pg_strcasecmp() is used instead of strcmp.
Attached is a patch having above changes.
Request the community to review the patch, if it makes sense.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-COPY-command-s-data-format-option-allows-only-low.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-06-24 10:34:12 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Fujii Masao | 2020-06-24 09:45:38 | Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762 |