| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint? |
| Date: | 2022-01-26 02:39:16 |
| Message-ID: | CALj2ACXGPpE_iiaegvTfM0WXf21aBCES=CoBZ8KAs2dFfeboog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 26, 2022 at 6:28 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jan 25, 2022 at 07:20:05PM +0000, Bossart, Nathan wrote:
> > I looked into removing the "shutdown" variable in favor of using
> > "flags" everywhere, but the patch was quite messy and repetitive. I
> > think another way to make things less confusing is to replace
> > "shutdown" with an inverse variable called "online." The attached
> > patch does it this way.
>
> Yeah, that sounds like a good compromise. At least, I find the whole
> a bit easier to follow.
v3 LGTM.
> Heikki was planning to commit a large refactoring of xlog.c, so we'd
> better wait for that to happen before concluding here.
Will that patch set fix the issue reported here?
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-01-26 02:51:40 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Amit Kapila | 2022-01-26 02:38:13 | Re: Skipping logical replication transactions on subscriber side |