| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Parallel autovacuum: DROP DATABASE WITH (FORCE) fails on the parallel workers |
| Date: | 2026-10-09 17:44:21 |
| Message-ID: | CALj2ACXBpfWpe8pzcrSt-17FqWCJ+UBx7QNYFtRwFgdbxp_xyA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Oct 8, 2026 at 10:52 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> > Yes, that's correct with the v2 patch. If we were to fix it for
> > parallel workers started by any bg worker (which I think we should),
> > the fix also needs to be back-patched. If agreed, I will check how far
> > back it needs to be back-patched and prepare patches.
>
> I'd fix it only in v19 for now. While the problem exists in the back
> branches too, it has never been reported in the field. Also the next
> minor release will be the final one for v14, there would be no chance
> to fix it there if this change turned out to be wrong. I think that If
> we get a report in the future, we can backpatch it.
Agreed.
> Fine with me. But probably can we remove leader->databaseId ==
> databaseId check? It seems redundant for parallel workers.
That's correct, but I would like to be more cautious here, so I
retained it. I also added a check that the parallel worker's
advertised role is the bootstrap superuser, again to be more cautious.
Please find the attached v3 patches. I split the TAP test into 0002.
Although I reviewed it closely, I don't have a strong opinion on
taking it (unless anyone thinks otherwise), I'm fine to leave it here
in the thread for the records.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-DROP-DATABASE-FORCE-to-terminate-autovacuum-p.patch | application/octet-stream | 5.5 KB |
| v3-0002-Add-test-for-DROP-DATABASE-FORCE-to-terminate-aut.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-10-09 17:47:06 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Manu | 2026-10-09 17:37:50 | Re: [PG19] Wrong results from Memoize with a nondeterministic collation |