| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes |
| Date: | 2021-11-28 06:55:47 |
| Message-ID: | CALj2ACX7foB8Rtn4-Z0HiueSMphB6=fDR4bUOSVC2Xft-8Fi5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 28, 2021 at 12:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > Attaching v4 patch, please review it further.
>
> One small comment:
> 1) There should be a space in between "<literal>LOG</literal>message level"
> + it can) for memory contexts. These memory contexts will be logged at
> + <literal>LOG</literal>message level. They will appear in the server log
> + based on the log configuration set (See <xref
> linkend="runtime-config-logging"/>
> + for more information), but will not be sent to the client regardless of
Done.
> The rest of the patch looks good to me.
Thanks for the review. Here's the v5 patch.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-enhance-pg_log_backend_memory_contexts-to-log-mem.patch | application/octet-stream | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-11-28 07:17:52 | Re: row filtering for logical replication |
| Previous Message | Bharath Rupireddy | 2021-11-28 06:52:45 | Re: Synchronizing slots from primary to standby |