| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Muhammad Usama <m(dot)usama(at)gmail(dot)com> |
| Subject: | Re: A new function to wait for the backend exit after termination |
| Date: | 2021-03-17 01:31:39 |
| Message-ID: | CALj2ACX3k7LetH66e=RWH8x9HqmXemFYFAqR1kTJgKMUcqwV4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 16, 2021 at 9:48 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Does it really make sense that pg_wait_for_backend_termination()
> defaults to waiting *100 milliseconds*, and then logs a warning? That
> seems extremely short if I'm explicitly asking it to wait.
I increased the default wait timeout to 5seconds.
> Wait events should be in alphabetical order in pgstat_get_wait_ipc()
> as well, not just in the header (which was adjusted per Fujii's
> comment)
Done.
>
> + (errmsg("could not wait for the termination of
> the backend with PID %d within %lld milliseconds",
>
> That's not true though? The wait succeeded, it just timed out? Isn't
> itm ore like "backend with PID %d did not terminate within %lld
> milliseconds"?
Looks better. Done.
Attaching v10 patch for further review.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-pg_terminate_backend-with-wait-and-timeout.patch | application/octet-stream | 12.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2021-03-17 01:34:23 | Re: cleanup temporary files after crash |
| Previous Message | Masahiro Ikeda | 2021-03-17 00:27:24 | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |