| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | BeginCopyTo - remove switching to old memory context in between COPY TO command processing |
| Date: | 2022-01-28 10:11:11 |
| Message-ID: | CALj2ACWvVa69foi9jhHFY=2BuHxAoYboyE+vXQTARwxZcJnVrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While reviewing patch at [1], it has been found that the memory
context switch to oldcontext from cstate->copycontext in between
BeginCopyTo is not correct because the intention of the copycontext is
to use it through the copy command processing. It looks like a thinko
from the commit c532d1 [2]. Attaching a small patch to remove this.
Thoughts?
[1] https://www.postgresql.org/message-id/539760.1642610324%40sss.pgh.pa.us
[2]
commit c532d15dddff14b01fe9ef1d465013cb8ef186df
Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Date: Mon Nov 23 10:50:50 2020 +0200
Split copy.c into four files.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-remove-switching-to-old-memory-context-in-between.patch | application/octet-stream | 720 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2022-01-28 10:45:41 | Re: refactoring basebackup.c |
| Previous Message | Amul Sul | 2022-01-28 10:10:24 | Re: TAP test to cover "EndOfLogTLI != replayTLI" case |