| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c |
| Date: | 2021-09-13 03:17:16 |
| Message-ID: | CALj2ACWis2_3eXO3WdscjrhGgXnMUNtQjXea9va7Vi5JHvNYpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 13, 2021 at 6:45 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>
> nitpick: It looks like there's an extra set of parentheses around
> errmsg().
>
> Indeed. Even the requirement for extra parenthesis around auxiliary function
> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).
The same commit says that the new code can be written in any way.
Having said that, I will leave it to the committer to take a call on
whether or not to remove the extra parenthesis.
"
While new code can be written either way, code intended to be
back-patched will need to use extra parens for awhile yet.
"
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-09-13 03:21:18 | Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c |
| Previous Message | Michael Paquier | 2021-09-13 03:14:26 | Re: TAP test for recovery_end_command |