| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add tests for concurrent DML retry paths in logical replication apply |
| Date: | 2026-11-17 19:24:16 |
| Message-ID: | CALj2ACWgjAX_s6dWFxAv6m2zodpMNREiTt=PAqTzyjZvD++xSg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sat, Jun 27, 2026 at 1:54 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Please find the attached v3 patch for further review. I would be happy
> to split this patch into two if necessary.
Upon thinking about this more, I would like to withdraw this from the
CF unless anyone thinks otherwise. I realize that testing resources
are not free. Also, the patch was not trying to fix a bug or improve
performance, and the change is not in a hot code path (concurrent
updates on the subscriber are relatively rare). Even if it were the
most common case, allocating a slot and materializing the tuple into a
new slot surely won't show up in perf profiles among other costs such
as applying the changes, waiting for tuples to be received from the
publisher, etc. So, I don't think it's worth the effort.
Thanks, and sorry for the noise.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-11-17 19:26:56 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |
| Previous Message | surya poondla | 2026-11-17 19:23:37 | Re: Bump soft open file limit (RLIMIT_NOFILE) to hard limit on startup |