| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-05-11 16:06:02 |
| Message-ID: | CALj2ACWbvEcc3HhP_m8aTCNOZmoeBaukF6W2_gd7+o7JhA=eKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 11, 2021 at 6:54 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Tue, May 11, 2021 at 2:47 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > On 2021-May-10, vignesh C wrote:
> >
> > > That sounds fine to me, Attached v6 patch which has the changes for the same.
> >
> > What about defining a function (maybe a static inline function in
> > defrem.h) that is marked noreturn and receives the DefElem and
> > optionally pstate, and throws the error? I think that would avoid the
> > patch's need to have half a dozen copies of the "duplicate_error:" label
> > and ereport stanza.
>
> Thanks for the comment, this reduces a significant amount of code.
Yeah, the patch reduces more than 200 LOC which is a pretty good thing.
25 files changed, 239 insertions(+), 454 deletions(-)
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-11 16:13:17 | Python 3.10 breaks regression tests with traceback changes |
| Previous Message | Tom Lane | 2021-05-11 16:03:33 | Some other CLOBBER_CACHE_ALWAYS culprits |