| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Kiran Kaki <itskkpg(at)gmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: pg_walinspect: fix LSN validation messages and empty range handling |
| Date: | 2026-11-12 18:03:17 |
| Message-ID: | CALj2ACWYoefJkRu9hkNCKLNL-CpY0UzkHNTb6ec82rB5xHSFHA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Sep 22, 2026 at 6:12 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> PFA v5:
Thanks for updating the patches.
0001 and 0002 LGTM. However, the new tests in 0002 are overkill, so I
would remove them.
I still think being consistent in the user-facing error messages is
good here. Core seems to use "less than or equal to" and "greater than
or equal to" elsewhere.
Since these are non-critical fixes, no back-patching for sure. I
marked it RfC and will leave it for the committers' interest.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-11-12 18:07:22 | Re: A gap in preventing bogus parameterizations in a798660ebe3 |
| Previous Message | Tom Lane | 2026-11-12 17:57:58 | Re: [PATCH] Report malformed integer aggregate states as array errors |