| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-04-30 05:13:21 |
| Message-ID: | CALj2ACWWHL+3-oDXkpn31bBYXxr7xhkNB0itaUvAvkbwqpxGhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 30, 2021 at 10:17 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> In this function, we already have the "defel" variable then I do not
> understand why you are using one extra variable and assigning defel to
> that?
> If the goal is to just improve the error message then you can simply
> use defel->defname?
Yeah. I can do that. Thanks for the comment.
While on this, I also removed the duplicate_error and procedure_error
goto statements, because IMHO, using goto statements is not an elegant
way. I used boolean flags to do the job instead. See the attached and
let me know what you think.
Just for completion, I also attached Vignesh's latest patch v3 as-is,
in case anybody wants to review it.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Enhance-error-message.patch | application/octet-stream | 47.4 KB |
| v2-0001-compute_common_attribute.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-04-30 05:19:13 | Re: Remove redundant variable from transformCreateStmt |
| Previous Message | Dilip Kumar | 2021-04-30 04:47:00 | Re: Enhanced error message to include hint messages for redundant options error |