| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values? |
| Date: | 2021-07-01 04:16:35 |
| Message-ID: | CALj2ACWPptcAR0Uaye6KdFnM2xp5FXWJhO+mCoo-sSoc7_3w2g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> The recent commit 61d599ede7 documented that the type of those options is
> floating point. But the docs still use "is a numeric value" in the descriptions
> of them. Probably it should be replaced with "is a floating point value" there.
> If we do this, isn't it better to use "floating point" even in the error message?
Agreed. PSA v5 patch.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Tighten-up-batch_size-fetch_size-options-against-.patch | application/octet-stream | 10.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-07-01 04:53:09 | Re: Preventing abort() and exit() calls in libpq |
| Previous Message | Amit Kapila | 2021-07-01 03:56:45 | Re: Skipping logical replication transactions on subscriber side |