| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values? |
| Date: | 2021-07-01 12:37:34 |
| Message-ID: | 01ce7089-75b3-aec5-64db-17f99d04cb5e@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/07/01 13:16, Bharath Rupireddy wrote:
> On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> The recent commit 61d599ede7 documented that the type of those options is
>> floating point. But the docs still use "is a numeric value" in the descriptions
>> of them. Probably it should be replaced with "is a floating point value" there.
>> If we do this, isn't it better to use "floating point" even in the error message?
>
> Agreed. PSA v5 patch.
Thanks for updating the patch! LGTM.
Barring any objection, I will commit this patch.
One question is; should we back-patch this? This is not a bug fix,
so I'm not sure if it's worth back-patching that to already-released versions.
But it may be better to do that to v14.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-07-01 12:41:10 | Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values? |
| Previous Message | Dean Rasheed | 2021-07-01 12:28:11 | Re: Numeric multiplication overflow errors |