| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit? |
| Date: | 2021-04-07 06:17:48 |
| Message-ID: | CALj2ACWOd9SWykgazp0NNyjy-R++m5=u=b3XWmaU547aTVNGiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 7, 2021 at 11:44 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Apr 07, 2021 at 06:31:19AM +0530, Bharath Rupireddy wrote:
> > Setting p->pd_flags = 0; is unnecessary and redundant after memsetting
> > the page to zeros. Also, see the existing code for pd_prune_xid,
> > similarly I've done that for pd_flags. I think it's okay with /*
> > p->pd_flags = 0; done by above MemSet */.
>
> Sure, but this one does not hurt much either as-is, so I have left it
> out, and applied the rest.
Thanks for pushing the patch.
I wanted to comment out p->pd_flags = 0; in PageInit similar to the
pd_prune_xid just for consistency.
/* p->pd_prune_xid = InvalidTransactionId; done by above MemSet */
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-04-07 06:43:05 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Thomas Munro | 2021-04-07 06:16:28 | Re: buildfarm instance bichir stuck |