Re: Simplify xlogreader.c with XLogRec* macros

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: 邱宇航 <iamqyh(at)gmail(dot)com>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, tmunro(at)postgresql(dot)org
Subject: Re: Simplify xlogreader.c with XLogRec* macros
Date: 2023-11-02 18:31:00
Message-ID: CALj2ACWOUm9yG-JKqAoQLdt1gUmeyNChhQBsxkXQpE+bnCVBbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 31, 2023 at 4:12 PM 邱宇航 <iamqyh(at)gmail(dot)com> wrote:
>
> >
> > I thought these can also be rewrite to:
> >
> > if (!XLogRecHasBlockRef(record, block_id))
>
> Oops, I missed that. New version is attached.

+1. Indeed a reasonable change. The attached v2 patch LGTM.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Morris 2023-11-02 19:00:56 Re: Including Doxyfile and Meson script for docs into main source tree
Previous Message Jeff Davis 2023-11-02 18:21:59 Re: Fix search_path for all maintenance commands