Fix a comment in WalSnd structure

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix a comment in WalSnd structure
Date: 2022-08-19 12:10:40
Message-ID: CALj2ACWE_7srye4_GZ=N=-rD=qr2WHL9GZrMnhWJOJ5RdnNS2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

WalSnd structure mutex is being used to protect all the variables of
that structure, not just 'variables shown above' [1]. A tiny patch
attached to fix the comment.

Thoughts?

[1]
diff --git a/src/include/replication/walsender_private.h
b/src/include/replication/walsender_private.h
index c14888e493..9c61f92c44 100644
--- a/src/include/replication/walsender_private.h
+++ b/src/include/replication/walsender_private.h
@@ -65,7 +65,7 @@ typedef struct WalSnd
*/
int sync_standby_priority;

- /* Protects shared variables shown above. */
+ /* Protects shared variables in this structure. */
slock_t mutex;

--
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/

Attachment Content-Type Size
v1-0001-Fix-a-comment-in-WalSnd-structure.patch application/x-patch 928 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-08-19 12:13:46 Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Previous Message Bharath Rupireddy 2022-08-19 12:09:37 Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)