| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Sergey Dudoladov <sergey(dot)dudoladov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: Is there a way (except from server logs) to know the kind of on-going/last checkpoint? |
| Date: | 2022-01-31 05:28:31 |
| Message-ID: | CALj2ACW1fLTX9vGgCj9PwdBwFvAGcjFZbxOnjWh0Aiz-h_MpFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 31, 2022 at 9:10 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Mon, Jan 31, 2022 at 11:10:45AM +0900, Kyotaro Horiguchi wrote:
> >
> > This means pg_controldata need to translate the flags into human-readable
> > text but, to be clear, I still don't think its usefull in the control
> > data.
>
> I've been saying that since my first email, I also don't see any scenario where
> having this specific information can be of any help.
>
> Given Andres feedback, unless someone can provide some realistic use case I
> think we should mark this patch as rejected and focus on a
> pg_progress_checkpoint feature. I will do so in a couple of days when I will
> close this commitfest.
The size of ControlFileData is 296 bytes currently and the sector
limit is of 512 bytes (PG_CONTROL_MAX_SAFE_SIZE), if we feel that this
extra 2 bytes of checkpoint flags isn't worth storing in the control
file, I'm pretty much okay with it.
Regards,
Bharath Rupireddy.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-01-31 05:29:33 | Re: Make relfile tombstone files conditional on WAL level |
| Previous Message | Michael Paquier | 2022-01-31 05:17:41 | Re: GUC flags |