| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: autovacuum: automatically propagate updated parameters |
| Date: | 2026-08-24 22:26:03 |
| Message-ID: | CALj2ACVqBnfnuve_Z6D256oB4-CEFDgjD-VU7sHNbE=48E7hOw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On Mon, Aug 24, 2026 at 3:16 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 25 Aug 2026, at 00:06, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> >
> >> I understand that having a test for this in the first place could have
> >> helped catch this issue. However, I don't see a strong point in having
> >> one now. Can we test it manually and get the fix alone?
> >
> > I mainly added the testcase as a repro, I am not sure how useful it is
> > as an actual test case. But if we want to keep it, I can certainly
> > reduce it.
>
> I think there is value in having a test, especially if we can roll it into 001
> as quick step.
+1. How about adding the test in the existing
001_parallel_autovacuum.pl instead of a new TAP test file?
> >> How about propagating the params to parallel workers launched by
> >> autovacuum right after updating cost limits in
> >> AutoVacuumUpdateCostLimit()?
> >
> > That could work too, I used the current location because most of the
> > parallel related things, including the other call to
> > parallel_vacuum_propagate_shared_delay_params is in vacuum.c, not in
> > autovacuum.c
>
> There is also strong value in not changing things too drastic at this point in
> the cycle.
Agreed. I'm fine with the v1 approach and backpatching to PG19.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Robert Haas | 2026-08-24 22:16:51 | Re: MERGE/SPLIT PARTITIONS issues/questions |