Re: autovacuum: automatically propagate updated parameters

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: autovacuum: automatically propagate updated parameters
Date: 2026-09-26 04:37:06
Message-ID: CALj2ACVnxudCDbi1DaxpkR=jLC4Ff01msAgL_w8W=P2EOeN3Aw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

On Fri, Sep 25, 2026 at 5:32 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> And it happens only when the number of workers sharing the cost limit
> changes. So I agree that it's acceptable, and given we're close to
> RC1, I'm fine with the SetLatch() approach.
>
> As for the 0001 patch, it looks good to me. I have one minor comment,
> though it's a matter of personal preference:

Thanks for reviewing it.

> +void
> +parallel_vacuum_refresh_cost_params(void)
>
> The second paragraph explains how this function is called. Since what
> the function does, as well as its name, is not specific to that wait,
> I guess it's better to explain it on the caller side, and the comment
> newly added in WaitForParallelWorkersToFinish() already explains a
> similar thing. Then the function comment can focus on what the
> function does and its side effects, such as reloading the
> configuration file. For example:
>
> /*
> * Reload the configuration file if requested, and refresh the cost-based
> * delay parameters of an autovacuum worker running a parallel vacuum
> * (leader), propagating any change to its parallel workers.
> */

Agreed.

Please find the attached v4 patches. 0002 remains the same.

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v4-0001-Refresh-autovacuum-costs-while-waiting-for-parall.patch application/octet-stream 6.9 KB
v4-0002-Add-tests-for-autovacuum-cost-parameter-refresh-w.patch application/octet-stream 13.1 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2026-09-26 06:26:06 BUG #19721: json_value with DEFAULT ON ERROR returns inconsistent results for NULL input in materialized CTE
Previous Message Masahiko Sawada 2026-09-26 00:31:22 Re: autovacuum: automatically propagate updated parameters