| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Do away with a few backwards compatibility macros |
| Date: | 2023-11-16 13:41:41 |
| Message-ID: | CALj2ACVeO58JM5tK2Qa8QC-=kC8sdkJOTd4BFU=K8zs4gGYpjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
After a recent commit 6a72c42f (a related discussion [1]) which
removed MemoryContextResetAndDeleteChildren(), I think there are a
couple of other backward compatibility macros out there that can be
removed. These macros are tuplestore_donestoring() which was
introduced by commit dd04e95 21 years ago and SPI_push() and friends
which were made no-ops macros by commit 1833f1a 7 years ago. Debian
code search shows very minimal usages of these macros. Here's a patch
attached to remove them.
Thoughts?
[1] https://www.postgresql.org/message-id/20231114175953.GD2062604%40nathanxps13
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Do-away-with-a-few-backwards-compatibility-macros.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-11-16 13:43:27 | Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro |
| Previous Message | Aleksander Alekseev | 2023-11-16 13:40:28 | Re: Trigger violates foreign key constraint |