| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve GetConfigOptionValues function |
| Date: | 2023-01-23 05:59:51 |
| Message-ID: | CALj2ACVZ1GEaALLVoKCbLiMpMW2fYJGVFSL-vbwT8-_yWnSg7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 19, 2023 at 3:27 PM Nitin Jadhav
<nitinjadhavpostgres(at)gmail(dot)com> wrote:
>
> > Possibly a better answer is to refactor into separate functions,
> > along the lines of
> >
> > static bool
> > ConfigOptionIsShowable(struct config_generic *conf)
> >
> > static void
> > GetConfigOptionValues(struct config_generic *conf, const char **values)
>
> Nice suggestion. Attached a patch for the same. Please share the
> comments if any.
The v2 patch looks good to me except the comment around
ConfigOptionIsShowable() which is too verbose. How about just "Return
whether the GUC variable is visible or not."?
I think you can add it to CF, if not done, to not lose track of it.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-01-23 06:08:51 | Re: Deadlock between logrep apply worker and tablesync worker |
| Previous Message | Jonathan S. Katz | 2023-01-23 05:58:40 | Re: User functions for building SCRAM secrets |