Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages
Date: 2022-03-02 06:11:49
Message-ID: CALj2ACVRUOGBCvVYBxnyrGA_fjbYJOb+N6Pn7rPqgN1QHsGxGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 1, 2022 at 6:50 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Mon, 28 Feb 2022 21:03:07 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> > Hi,
> >
> > It looks like we use "log segment" in various user-facing messages.
> > The term "log" can mean server logs as well. The "WAL segment" suits
> > well here and it is consistently used across the other user-facing
> > messages [1].
> >
> > Here's a small patch attempting to consistently use the "WAL segment".
> >
> > Thoughts?
>
> I tend to agree to this.

Thanks for taking a look at it. Here's the CF entry -
https://commitfest.postgresql.org/38/3584/

> I also see "log record(s)" (without prefixed
> by "write-ahead") in many places especially in the documentation. I'm
> not sure how we should treat "WAL log", though.

Yes, but the docs have a glossary term for 'Log record" [1]. FWIW
attaching docs change as v2-0002 patch. I found another place where
"log records" is being used in pg_waldump.c, I changed that and
attached v2-0001 patch.

Please review the v2 patch set.

[1]
<glossentry id="glossary-log-record">
<glossterm>Log record</glossterm>
<glossdef>
<para>
Archaic term for a <glossterm linkend="glossary-wal-record">WAL
record</glossterm>.
</para>
</glossdef>
</glossentry>

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v2-0001-Use-WAL-segment-instead-of-log-segment.patch application/x-patch 9.0 KB
v2-0002-Replace-log-record-with-WAL-record-in-docs.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-02 06:37:19 Re: more descriptive message for process termination due to max_slot_wal_keep_size
Previous Message Masahiko Sawada 2022-03-02 05:39:54 Re: Add the replication origin name and commit-LSN to logical replication worker errcontext