| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Implement generalized sub routine find_in_log for tap test |
| Date: | 2023-06-06 04:30:00 |
| Message-ID: | CALj2ACVQovWdxd1C9K86JAtG4mTbh86qqXfKHjWw0BeLXAHE3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 5, 2023 at 9:39 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Sun, 4 Jun 2023 at 03:51, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > This looks like a typo to me, the log offset is eaten.
> >
> > Except of that, I am on board with log_contains().
>
> Thanks for fixing this.
+1 for deduplicating find_in_log. How about deduplicating advance_wal
too so that 019_replslot_limit.pl, 033_replay_tsp_drops.pl,
035_standby_logical_decoding.pl and 001_stream_rep.pl can benefit
immediately?
FWIW, a previous discussion related to this is here
https://www.postgresql.org/message-id/flat/CALj2ACVUcXtLgHRPbx28ZQQyRM6j%2BeSH3jNUALr2pJ4%2Bf%3DHRGA%40mail.gmail.com.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-06-06 05:13:36 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Alexander Pyhalov | 2023-06-06 04:19:01 | Re: Partial aggregates pushdown |