Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Date: 2021-10-25 09:14:51
Message-ID: CALj2ACVOhXjSzGGcONqss0ucdEZ2jBdUjioTBrjS_wtwP1r=xQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Oct 24, 2021 at 10:34 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> > 5) The following change is being handled in the patch at [3], I know
> > it is appropriate to have it in this patch, but please mention it in
> > the commit message on why we do this change. I will remove this
> > change
> > from my patch at [3].
> > -SELECT * FROM pg_log_backend_memory_contexts(pg_backend_pid());
> > +SELECT pg_log_backend_memory_contexts(pg_backend_pid());
>
> What would you like me to mention?

Something like below in the commit message would be good:
"While on this, change the way the tests use pg_log_backend_memory_contexts()
Usually for functions, we don't use "SELECT-FROM-<<function>>",
we just use "SELECT-<<function>>"."

Regards,
Bharath Rupireddy.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-10-25 09:19:57 Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Previous Message Amul Sul 2021-10-25 09:12:28 Re: TAP test for recovery_end_command