| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] ALTER SYSTEM READ ONLY |
| Date: | 2021-04-05 11:15:32 |
| Message-ID: | CALj2ACVLfvqsjXQ18zSG_qaDAYNQ3-AvUQFDK_=CSRp0Cbye5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 5, 2021 at 11:02 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> Attached is the rebase version for the latest master head(commit # 9f6f1f9b8e6).
Some minor comments on 0001:
Isn't it "might not be running"?
+ errdetail("Checkpointer might not running."),
Isn't it "Try again after sometime"?
+ errhint("Try after sometime again.")));
Can we have ereport(DEBUG1 just to be consistent(although it doesn't
make any difference from elog(DEBUG1) with the new log messages
introduced in the patch?
+ elog(DEBUG1, "waiting for backends to adopt requested WAL
prohibit state change");
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-04-05 11:30:00 | Re: New IndexAM API controlling index vacuum strategies |
| Previous Message | Masahiro Ikeda | 2021-04-05 10:20:20 | Re: Why reset pgstat during recovery |