| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kiran Kaki <itskkpg(at)gmail(dot)com> |
| Subject: | Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views |
| Date: | 2026-08-31 21:29:25 |
| Message-ID: | CALj2ACVAcXZ+OLmqqaa44hD8vsQCQFnjb8UatC+xhq4kkGfvJg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, Aug 31, 2026 at 1:50 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> > I think this should reuse errdetail_relkind_not_supported().
>
> Yes, that's better, let's reuse.
>
> > I would
> > add a trivial test as Kiran Kaki suggested though.
>
> That's fine with me, I can add one for materialized views here in this
> patch.
Please find the attached v2.
> Going by this, I think we also need tests for catalogs, TOAST,
> and other repack-restricted cases. I'd let Kiran Kaki add such tests
> in a new thread.
I realized that except for the wal_level and replica identity related
errors, repack seems to already have tests for the other restricted
cases.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-error-message-for-concurrent-repack-on-materi.patch | application/x-patch | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | surya poondla | 2026-08-31 21:42:51 | Re: [PATCH] Clarify that ssl_groups is for any key exchange groups |
| Previous Message | Paul A Jungwirth | 2026-08-31 21:28:08 | Add TG_* vars for FOR PORTION OF |