Re: psql: add tab completion for subscription wal_receiver_timeout

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: psql: add tab completion for subscription wal_receiver_timeout
Date: 2026-06-24 05:06:36
Message-ID: CALj2ACV0XCqsDyEKU26s-cbbjdgqc_77ZLBFuD-uh2d3FWEo5w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Jun 23, 2026 at 8:50 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> Hi,
>
> While testing "[fb80f388f] Add per-subscription wal_receiver_timeout setting", I noticed that wal_receiver_timeout is missing from tab completion for both CREATE SUBSCRIPTION WITH and ALTER SUBSCRIPTION SET:
> ```
> evantest=# create subscription ss with (
> BINARY CREATE_SLOT FAILOVER PASSWORD_REQUIRED SLOT_NAME TWO_PHASE
> CONNECT DISABLE_ON_ERROR MAX_RETENTION_DURATION RETAIN_DEAD_TUPLES STREAMING
> COPY_DATA ENABLED ORIGIN RUN_AS_OWNER SYNCHRONOUS_COMMIT
> evantest=# alter subscription ss set (
> BINARY FAILOVER ORIGIN RETAIN_DEAD_TUPLES SLOT_NAME SYNCHRONOUS_COMMIT
> DISABLE_ON_ERROR MAX_RETENTION_DURATION PASSWORD_REQUIRED RUN_AS_OWNER STREAMING TWO_PHASE
> ```
>
> This is a tiny patch to fix that.

Thanks for the patch.

LGTM.

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-06-24 05:09:00 Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Previous Message Bharath Rupireddy 2026-06-24 04:47:11 Re: enhance wraparound warnings