| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE |
| Date: | 2026-07-04 05:26:00 |
| Message-ID: | CALj2ACUhhxChS0viUYP7hGqj+L5U38UPKXxAPX-bpHraAzO5mw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Jun 30, 2026 at 10:38 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> While changes to pg_get_publication_tables() look good to me,
Thanks for reviewing!
> I think
> the regression tests should be implemented as an isolation test rather
> than a TAP test in 100_bugs.pl as it can be tested without subscribers
> and the isolation test works well for this kind of race condition
> tests.
Agreed. The isolation test avoids the extra publisher start/stop the
TAP version needed, and it's about the same amount of code. Please
find the attached v9 patches.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Fix-pg_get_publication_tables-race-with-concurren.patch | application/octet-stream | 8.6 KB |
| v9-0001-REL19-Fix-pg_get_publication_tables-race-with-concurrent-DROP.patch | application/octet-stream | 8.6 KB |
| v9-0001-REL18-Fix-pg_get_publication_tables-race-with-concurrent-DROP.patch | application/octet-stream | 8.4 KB |
| v9-0001-REL17-Fix-pg_get_publication_tables-race-with-concurrent-DROP.patch | application/octet-stream | 8.4 KB |
| v9-0001-REL16-Fix-pg_get_publication_tables-race-with-concurrent-DROP.patch | application/octet-stream | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Thomas Munro | 2026-07-04 04:44:47 | MinGW ccache snafu on CI |