| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a typo in pg_rotate_logfile |
| Date: | 2024-02-16 07:22:47 |
| Message-ID: | CALj2ACUf4BKfuk6MAYiN6zQGFJdg0tRR6Df68X4Xj6YsnSX4PA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 15, 2024 at 2:18 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> >>> Searching on Github and Debian Codesearch I cannot find any reference to anyone
> >>> using any function from adminpack. With pgAdminIII being EOL it might be to
> >>> remove it now rather than be on the hook to maintain it for another 5 years
> >>> until v17 goes EOL. It'll still be around for years in V16->.
> >>
> >> Works for me.
> >>
> >>> Attached is a diff to show what it would look like to remove adminpack (catalog
> >>> version bump omitted on purpose to avoid conflicts until commit).
> >>
> >> I don't see any references you missed, so +1.
> >
> > Seems reasonable to me, too.
>
> Thanks! I'll put this in the next CF to keep it open for comments a bit
> longer, but will close it early in the CF.
LGTM.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-02-16 07:38:45 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |
| Previous Message | Bertrand Drouvot | 2024-02-16 06:47:24 | Re: Synchronizing slots from primary to standby |