Re: Support for 8-byte TOAST values, round two

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Greg Burd <greg(at)burd(dot)me>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support for 8-byte TOAST values, round two
Date: 2026-09-21 22:39:23
Message-ID: CALj2ACUdXAngMaoPD_EFCPDha8AnqFwBmO8bOUgkucYOuYmf4w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Sep 21, 2026 at 4:11 AM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Tue, Sep 15, 2026 at 2:08 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > Thanks. I have spent the day processing all these free, and finally
> > applied the set.
>
> Nice work!
>
> It looks like doc/src/sgml/limits.sgml needs to be updated as well.

Nice catch. Thanks for pointing it out. Please find the attached patch for that.

I also attached the 0001 and 0002 from
https://www.postgresql.org/message-id/CALj2ACUmBhBGb%2B4d8SRq9JT\_ZsObCAvY6-10CKgSWX98zdv2DQ%40mail.gmail.com
here as 0002 and 0003.

In the attached 0003, I fixed an issue with the remote version check
and simplified the tests by reusing an existing table whose reloption
is already reset, and verifying that the dump reports the original
TOAST type. This is good enough to cover the new code without starting
a new instance just to test this. I also used a join instead of a
per-relation lookup in the query to get the TOAST type, which avoids
an extra catalog lookup for every table.

Please have a look.

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-doc-Note-the-oid8-out-of-line-value-limit-in-the-.patch application/octet-stream 2.3 KB
v1-0002-doc-Describe-how-to-change-the-chunk_id-type-of-a.patch application/octet-stream 3.7 KB
v1-0003-pg_dump-Preserve-the-chunk_id-type-of-a-TOAST-tab.patch application/octet-stream 9.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2026-09-21 22:45:32 Re: [PATCH] Explain what the default output_plugin_libraries do
Previous Message Bryan Green 2026-09-21 22:28:58 Re: [PATCH] unrecognized win32 error 448 (ERROR_UNTRUSTED_MOUNT_POINT) breaks tablespaces on Win11 26200