From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Improvements and additions to COPY progress reporting |
Date: | 2021-03-04 06:51:40 |
Message-ID: | CALj2ACUSDbuewVuvYL-AL0nGfYHag21rKgu0Uqpvdn4PVxw7Hw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 24, 2021 at 1:23 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Sun, Feb 21, 2021 at 08:10:09PM +0100, Matthias van de Meent wrote:
> > Subject: [PATCH v9 1/3] Add progress-reported components for COPY progress
> > reporting
>
> > /* Increment amount of processed tuples and update the progress */
> > /* Increment amount of processed tuples and update the progress */
>
> Ideally, this would say "number of processed tuples"
Correct. It's introduced by the original COPY progress reporting
patch. Having said that, we could just correct them in the 0001 patch.
> Looking at the existing docs:
>
> https://www.postgresql.org/docs/devel/progress-reporting.html#COPY-PROGRESS-REPORTING
> | OID of the table on which the COPY command is executed
>
> Maybe it should say ".. is executing". Or ".. being executed":
> | OID of the table on which the COPY command is being executed
+1 for changing it to "OID of the table on which the COPY command is
being executed."
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-03-04 06:53:22 | Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW |
Previous Message | Kyotaro Horiguchi | 2021-03-04 06:50:39 | Re: Make mesage at end-of-recovery less scary. |