Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date: 2021-09-11 08:28:42
Message-ID: CALj2ACUPpVw1u7sQocFVWrSs0n10pt_G_4NPZKSxXK6cW1dErw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

We have two static check_permissions functions (one in slotfuncs.c
another in logicalfuncs.c) with the same name and same code for
checking the privileges for using replication slots. Why can't we have
a single function CheckReplicationSlotPermissions in slot.c? This way,
we can get rid of redundant code. Attaching a patch for it.

Thoughts?

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v1-0001-replication-slots-remove-duplicate-code-for-check.patch application/octet-stream 4.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2021-09-11 12:31:37 Compressing temporary files
Previous Message Jaime Casanova 2021-09-11 06:35:27 Re: Polyphase merge is obsolete