Re: Improvements and additions to COPY progress reporting

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improvements and additions to COPY progress reporting
Date: 2021-03-04 06:46:17
Message-ID: CALj2ACUK_pJbwcamMaHm4hqKch++Ca35PtpHzeOAWFaCc5up7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 25, 2021 at 1:44 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Feb 24, 2021 at 01:53:03AM -0600, Justin Pryzby wrote:
> > On Sun, Feb 21, 2021 at 08:10:09PM +0100, Matthias van de Meent wrote:
> > I think these should say that they report their progress *in* the view (not
> > "to"):
> >
> > > + Each backend running <command>ANALYZE</command> will report its progress to
> > > + the <structname>pg_stat_progress_analyze</structname> view. See
>
> What is proposed in the patch is:
> "Each backend running <command>blah</> will report its progress to the
> pg_stat_progress_blah view."
>
> What you propose is:
> "Each backend running <command>blah</> will report its progress in the
> pg_stat_progress_blah view."

IMO, the phrasing proposed by Justin upthread looks good. It's like this:

> + Each backend running <command>ANALYZE</command> will report its progress in
> + the <structname>pg_stat_progress_analyze</structname> view. See

> + Each backend running <command>CREATE INDEX</command> will report its
> + progress in the <structname>pg_stat_progress_create_index</structname> view

...
...

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-03-04 06:50:39 Re: Make mesage at end-of-recovery less scary.
Previous Message Pavel Stehule 2021-03-04 06:37:04 Re: proposal - psql - use pager for \watch command