Re: Fix ALTER SUBSCRIPTION ... SET PUBLICATION documentation

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: japin <japinli(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix ALTER SUBSCRIPTION ... SET PUBLICATION documentation
Date: 2021-01-27 11:47:04
Message-ID: CALj2ACU3yVuqv174D1W+mZPuGsA-wtPc22vN9qm_E+r6BFFJBA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 27, 2021 at 4:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jan 26, 2021 at 4:56 PM japin <japinli(at)hotmail(dot)com> wrote:
> >
> >
> > Hi,
> >
> > When I read the documentation of ALTER SUBSCRIPTION ... SET PUBLICATION ... WITH (...),
> > it says "set_publication_option" only support "refresh" in documentation [1].
> > However, we can also supply the "copy_data" option, and the code is:
> >
>
> I think there is a reference to the 'copy_data' option as well. There
> is a sentence saying: "Additionally, refresh options as described
> under REFRESH PUBLICATION may be specified." and then if you Refresh
> option, there we do mention about 'copy_data', isn't that sufficient?

Right. It looks like the copy_option is indirectly mentioned with the
statement "Additionally, refresh options as described under REFRESH
PUBLICATION may be specified." under "set_publication_option". IMHO,
we can keep it that way.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-01-27 13:02:35 Re: simplifying foreign key/RI checks
Previous Message Bharath Rupireddy 2021-01-27 11:41:38 Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax