Re: Parallel Inserts in CREATE TABLE AS

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Luc Vlaming <luc(at)swarm64(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel Inserts in CREATE TABLE AS
Date: 2020-12-30 03:55:33
Message-ID: CALj2ACU2x6pkT65C2ALFZ+5R_+GJF0=5td8EKMUXBj5-3ZSvUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 30, 2020 at 5:22 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> w.r.t. v17-0004-Enable-CTAS-Parallel-Inserts-For-Append.patch
>
> + * Push the dest receiver to Gather node when it is either at the top of the
> + * plan or under top Append node unless it does not have any projections to do.
>
> I think the 'unless' should be 'if'. As can be seen from the body of the method:
>
> + if (!ps->ps_ProjInfo)
> + {
> + GatherState *gstate = (GatherState *) ps;
> +
> + parallel = true;

Thanks. Modified it in the 0004 patch. Attaching v18 patch set. Note
that no change in 0001 to 0003 patches from v17.

Please consider v18 patch set for further review.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v18-0001-Parallel-Inserts-in-CREATE-TABLE-AS.patch application/octet-stream 27.7 KB
v18-0002-Tuple-Cost-Adjustment-for-Parallel-Inserts-in-CTAS.patch application/octet-stream 14.9 KB
v18-0003-Tests-And-Docs-For-Parallel-Inserts-in-CTAS.patch application/octet-stream 29.8 KB
v18-0004-Enable-CTAS-Parallel-Inserts-For-Append.patch application/octet-stream 45.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-12-30 03:57:36 Re: WIP: WAL prefetch (another approach)
Previous Message Bharath Rupireddy 2020-12-30 03:49:55 Re: Consider Parallelism While Planning For REFRESH MATERIALIZED VIEW