| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Luc Vlaming <luc(at)swarm64(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Inserts in CREATE TABLE AS |
| Date: | 2020-12-29 23:53:46 |
| Message-ID: | CALNJ-vRMU+7w01=grs7gF5oXFPpUedoLAdf2TgFnDtiUGp+72w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
w.r.t. v17-0004-Enable-CTAS-Parallel-Inserts-For-Append.patch
+ * Push the dest receiver to Gather node when it is either at the top of
the
+ * plan or under top Append node unless it does not have any projections
to do.
I think the 'unless' should be 'if'. As can be seen from the body of the
method:
+ if (!ps->ps_ProjInfo)
+ {
+ GatherState *gstate = (GatherState *) ps;
+
+ parallel = true;
Cheers
On Mon, Dec 28, 2020 at 4:12 AM Bharath Rupireddy <
bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Mon, Dec 28, 2020 at 10:46 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> wrote:
> > Thanks for working on this, I will have a look at the updated patches
> soon.
>
> Attaching v17 patch set after addressing comments raised in other
> threads. Please consider this patch set for further review.
>
>
> With Regards,
> Bharath Rupireddy.
> EnterpriseDB: http://www.enterprisedb.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-12-30 01:57:57 | Re: Lazy JIT IR code generation to increase JIT speed with partitions |
| Previous Message | Justin Pryzby | 2020-12-29 23:08:05 | Re: create table like: ACCESS METHOD |