From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
Date: | 2022-10-31 06:20:27 |
Message-ID: | CALj2ACU1QYN4RQBT_FG7sMrAATLSrTpziDzHNj122ZRLQ5yDsQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Oct 31, 2022 at 5:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Oct 30, 2022 at 03:44:32PM +0100, Alvaro Herrera wrote:
> > So I'm kinda proposing that we only do the forward struct initialization
> > dance when it really saves on things -- in particular, when it helps
> > avoid or reduce massive indirect header inclusion.
>
> Sure.
I don't think including pg_iovec.h in file_utils.h is a good idea. I
agree that pg_iovec.h is fairly a small header file but file_utils.h
is included in 21 .c files, as of today and the file_utils.h footprint
might increase in future. Therefore, I'd vote for forward struct
initialization as it is on HEAD today.
> > extern ssize_t pg_pwritev_with_retry(int fd,
> > - const struct iovec *iov,
> > + const iovec *iov,
> > int iovcnt,
> > off_t offset);
>
> However this still needs to be defined as a struct, no?
Yes, we need a struct there because we haven't typedef'ed struct iovec.
Also, the patch forgets to remove "port/pg_iovec.h" from file_utils.c
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2022-10-31 06:21:48 | Re: GUC values - recommended way to declare the C variables? |
Previous Message | Zhang Mingli | 2022-10-31 06:15:49 | Re: Lock on ShmemVariableCache fields? |