| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, alvherre(at)kurilemu(dot)de |
| Subject: | Re: REPACK (CONCURRENTLY) rewrites tables marked with user_catalog_table |
| Date: | 2026-09-04 19:59:18 |
| Message-ID: | CALj2ACU-ZENaQ_tZeD-KQdds9zM2mN1eP9oYO9dmmqmM2-tFTw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Sep 4, 2026 at 11:02 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I reviewed the patch. It's simple and I agree to add a check for user
> catalog tables. I've slightly rephrased the comment in
> check_concurrent_repack_requirements() to clarify the reason why
> REPACK (CONCURRENTLY) doesn't support user catalog tables while it
> does for normal tables even though it's a MVCC-unsafe operation. Also
> updated the commit message as well. Please review it.
Thanks for reviewing it. The v4 patch looks good to me. pgindent and
make check are happy.
A nit:
Code comment:
+ * tables under a historic snapshot. Removing this check requires making
+ * it MVCC-safe and logical rewrite mappings.
+ */
Commit message:
Disallow REPACK (CONCURRENTLY) on user catalog tables. Removing this
check requires making it MVCC-safe and logical rewrite mappings.
"Making it logical rewrite mappings" doesn't read correctly. How about
"Removing this check requires making it MVCC-safe and adding logical
rewrite mapping support" or such?
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Paul A Jungwirth | 2026-09-04 19:42:04 | Improve error hint for already-modified rows under FOR PORTION OF |