Re: [PATCH] COPY command's data format option allows only lowercase csv, text or binary

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] COPY command's data format option allows only lowercase csv, text or binary
Date: 2020-06-29 06:08:54
Message-ID: CALj2ACU+RFPAXsBJvBhUoWOUWqCjx=zmqXo3qdobmpMwK-3OKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> As that shows, there's already a round of lowercasing done by the parser.
> The only way that strcasecmp in copy.c would be useful is if you wanted to
> accept things like
> copy foo from stdin (format "CSV");
> I don't find that to be a terribly good idea. The normal implication
> of quoting is that it *prevents* case folding, so why should that
> happen anyway?
>

I was able to know that the parser does the lowercasing for other
parts of the query,
what I missed in my understanding is that about the proper usage of quoting.

Thanks for letting me know this point.

I agree with the above understanding to not change that behavior.

Please ignore this patch.

Thank you all for your responses.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-06-29 06:13:13 Re: Creating a function for exposing memory usage of backend process
Previous Message Tharakan, Robins 2020-06-29 05:48:35 track_planning causing performance regression