| From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: heapam_index_build_range_scan's anyvisible |
| Date: | 2019-06-10 20:48:54 |
| Message-ID: | CALfoeis6=8ehuR=VNtHvj3z16cYfCwPdTcpaxU+sfSUJ5QgR3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 7, 2019 at 1:19 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I spent some time today studying heapam_index_build_range_scan and
> quickly reached the conclusion that it's kind of a mess.
>
While at it might be helpful and better to also decouple HeapTuple
dependency for
IndexBuildCallback. Currently, all AM needs to build HeapTuple in
index_build_range_scan function. I looked into all the callback functions
and only htup->t_self is used from heaptuple in all the functions (unless I
missed something). So, if seems fine will be happy to write patch to make
that argument ItemPointer instead of HeapTuple?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hsu, John | 2019-06-10 21:08:46 | ERROR: subtransaction logged without previous top-level txn record |
| Previous Message | Goel, Dhruv | 2019-06-10 20:22:16 | Re: Avoiding deadlock errors in CREATE INDEX CONCURRENTLY |