Re: Event trigger table rewrite doc missing ALTER MATERIALIZED VIEW case

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Event trigger table rewrite doc missing ALTER MATERIALIZED VIEW case
Date: 2026-10-26 11:39:33
Message-ID: CALdSSPjxek6UvVusEvw6wvrJ0ZUr1UyRxx+huCiC1_npFo=bmg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 26 Oct 2026 at 09:29, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Sunday, October 25, 2026, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>>
>> Suggested fix:
>>
>> diff --git a/doc/src/sgml/event-trigger.sgml b/doc/src/sgml/event-trigger.sgml
>> --- a/doc/src/sgml/event-trigger.sgml
>> +++ b/doc/src/sgml/event-trigger.sgml
>> @@ -150,7 +150,8 @@
>> <para>
>> The <literal>table_rewrite</literal> event occurs just before a table is
>> - rewritten by some actions of the commands <literal>ALTER TABLE</literal>
>> - and <literal>ALTER TYPE</literal>. While other
>> + rewritten by some actions of the commands <literal>ALTER TABLE</literal>,
>> + <literal>ALTER MATERIALIZED VIEW</literal> and <literal>ALTER
>> TYPE</literal>.
>> + While other
>>

Hi, thats for looking.

> Probably should also edit: …just before a table [or materialized view] is rewritten…
>
> This seems like it should be back-patched thru v15.
>
> I’d be a bit more wordy here to connect the unexpected alter type action to typed tables explicitly.

Did that, PFA my version of wording. Applicable from master down to v18.

> David J.
>

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v2-master-18-19-table-rewrite.diff application/octet-stream 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2026-10-26 11:42:16 Re: Return pg_control from pg_backup_stop().
Previous Message Aleksander Alekseev 2026-10-26 11:28:18 Re: SERIALIZABLE can commit write skew after SSI summarization