| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Define DatumGetInt8 function. |
| Date: | 2026-01-06 14:12:33 |
| Message-ID: | CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 6 Jan 2026 at 16:50, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Tue, 30 Dec 2025 at 05:01, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > Well, OK. Removal is also fine for me, because it is at least consistent.
>
> Kirill, are you working on this patch?
Hi!
Yes, PFA.
> I've not studied in detail,
> but looks like it would require making
> char_decrement()/char_increment() and btcharskipsupport() all use
> CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
> rather than 0/UCHAR_MAX.
This is also a possible change, and can be a separate patch. I will
try to also work on this this week.
--
Best regards,
Kirill Reshke
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-Int8GetDatum-function.patch | application/octet-stream | 871 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-01-06 14:12:50 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Ramakrishna Reddy Nandyala | 2026-01-06 13:59:29 | Page verification failed, calculated Checksum 1065 but expected 42487 |