Re: Display is_prev_bucket_same_wrt of xl_hash_squeeze_page

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Display is_prev_bucket_same_wrt of xl_hash_squeeze_page
Date: 2025-09-11 08:35:11
Message-ID: CALdSSPjGqCWJ=QizMPkXUvf-uZhTeNT6AC1j2hh2G5=C3jYfQw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

HI, thanks for looking into this.

On Thu, 11 Sept 2025 at 05:54, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> We are still missing the offsets in xl_hash_vacuum_one_page, which
> would lead to a longer output, with perhaps less value in in.

Yes. I guess we might want to implement this to keep things in sync:
we display dead/redirected tuple offsets in PRUNE VACUUM SCAN output
already, so maybe just display here too, this is also vacuum.

> How about old_bucket_flag and new_bucket_flag in
> xl_hash_split_allocate_page, as well as procid in
> xl_hash_init_meta_page? While we are looking at this area, we may as
> well close the gap in the output produced.

Sure

PFA v2.

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v2-0001-Display-more-fields-of-xl_hash-wal-records.patch application/octet-stream 2.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vitaly Davydov 2025-09-11 08:35:36 ALTER DATABASE RESET with unexistent guc doesn't report an error
Previous Message Tomas Vondra 2025-09-11 08:32:40 Re: Adding basic NUMA awareness