| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: citext_1.out, citext.out confusing comment |
| Date: | 2025-12-09 07:30:51 |
| Message-ID: | CALdSSPj6i=5w8hEAgxMtKxVQiW5+rJX9bxkzAhY2pRgRz8bx8w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 9 Dec 2025, 10:08 jian he, <jian(dot)universality(at)gmail(dot)com> wrote:
> hi.
>
> While working on CAST DEFAULT, I found out citext_1.out, citext.out
> comments are
> confusing.
>
> contrib/citext/expected/citext_1.out:
> SELECT 'a'::citext >= 'B'::text AS t; -- text wins.
> t
> ---
> f
> (1 row)
>
>
> contrib/citext/expected/citext.out:
> SELECT 'a'::citext >= 'B'::text AS t; -- text wins.
> t
> ---
> t
> (1 row)
>
> same input, return different result, The comment "-- text wins."
> seems confusing.
> (this happens in other places within citext.out, citext_1.out).
>
Well, that's because there is single sql test file, so no variation here is
possible. We can simply delete comment, or we can rephrase it to reflect,
under which conditions text wins
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yu Wang | 2025-12-09 08:21:57 | Re: Add mode column to pg_stat_progress_vacuum |
| Previous Message | Bertrand Drouvot | 2025-12-09 07:27:03 | Re: Safer hash table initialization macro |