| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2025-12-22 05:47:37 |
| Message-ID: | CALdSSPj65eWgR33KgZAKufpikm535UpRo3AbupqJ_fi4gpPpZw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 22 Dec 2025 at 03:02, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Sun, Dec 21, 2025 at 9:42 AM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > Hi! Your v2 looks fine
> > The only question for me is, should we add any regression test to exercise this code, or it is not worth the troubles?
>
> I've checked contents of out regression tests. I see we very rarely
> include SQLSTATE there, mostly in psql and plpgsql tests. Thus, I
> think we should just fix the SQLSTATE without dedicating a test for
> that. So, I'm going to push the patch from Tender Wang if no
> objections.
Ok, no objections.
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-12-22 06:07:27 | Re: Skipping schema changes in publication |
| Previous Message | Amit Kapila | 2025-12-22 05:38:39 | Re: Logical Replication of sequences |