| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix inconsistencies with code and beautify xlog structures description and fin hash_xlog.h |
| Date: | 2025-09-05 06:17:53 |
| Message-ID: | CALdSSPj1j=a1d1hVA3oabRFz0hSU3KKrYtZPijw4UPUM7LY9zw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers!
While doing some xlog-related task at my job I noticed inconsistency
between [0] & [1]. hash_xlog.h xl_hash_squeeze_page structure
description mismatches with actual code.
PFA fixing issue.
I also allowed myself to standardise description of
xl_hash_move_page_contents and xl_hash_init_bitmap_page, so
xl_hash_delete, xl_hash_init_bitmap_page and
xl_hash_move_page_contents describes their zeroth backup block akin to
each other.
[0] https://git.postgresql.org/cgit/postgresql.git/tree/src/include/access/hash_xlog.h?id=567d27e8e2b752743626eb259ba75ecdc936eaf3#n147
[1] https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/access/hash/hash_xlog.c?id=567d27e8e2b752743626eb259ba75ecdc936eaf3#n830
--
Best regards,
Kirill Reshke
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-comments-in-xlog.h.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-09-05 06:24:48 | Re: Fix inconsistencies with code and beautify xlog structures description and fin hash_xlog.h |
| Previous Message | shveta malik | 2025-09-05 06:01:27 | Re: Conflict detection for update_deleted in logical replication |