Re: Add missing stats_reset column to pg_stat_database_conflicts view

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add missing stats_reset column to pg_stat_database_conflicts view
Date: 2026-03-10 11:32:02
Message-ID: CALdSSPi4apueVqgnJEZqpy6O0HSEPUiUzf=vTLPPijsQLob2Eg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 10 Mar 2026 at 06:17, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Mar 10, 2026 at 8:33 AM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> >
> > > The attached patch adds pg_stat_get_db_stat_reset_time() to fix this
> > > inconsistency.
> > >
> > > Please let me know your thoughts.
> >
> > This view was introduced 15 years ago, and surprisingly this is the
> > first complaint about this. I am also not very surprised.
> >
> > I also noticed that pg_statio_all_sequences does not have a reset
> > column. We should fix this one also. What do you think?
>
> +1
>
> Also it might be better to update the docs together so that the description of
> pg_stat_reset_single_table_counters mentions sequences in addition to
> tables and indexes.
>
> Regards,
>
> --
> Fujii Masao
>

Well, it looks like there are not so many users of this view. Anyway,
+1 on change.
This also need catversion bump

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2026-03-10 11:42:28 Re: Speed up COPY FROM text/CSV parsing using SIMD
Previous Message Jim Jones 2026-03-10 11:16:40 Re: ALTER TABLE: warn when actions do not recurse to partitions