Re: Add missing CHECK_FOR_INTERRUPTS calls in dblink module

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add missing CHECK_FOR_INTERRUPTS calls in dblink module
Date: 2026-03-10 09:25:10
Message-ID: CALdSSPhuCN_cS7MXobWx7Lh0adc-NWd8M115QMGC+yf21kCgNg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 10 Mar 2026 at 14:00, Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> wrote:
>
> Hi All,
>
> This is my first patch submission, please guide me if I made any mistakes. I noticed that CHECK_FOR_INTERRUPTS is missing at two places in dblink.c. Submitting a small patch to address this.
>
> Regards,
> Lakshmi
>
>

Hi!
Are you trying to fix any real problem? So, do you have any reproduces
where dblink stucks while processing tuples? I am somehow surprised if
we do not have CFI somewhere inside tuplestore_puttuple...

--
Best regards,
Kirill Reshke

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2026-03-10 09:28:53 Re: Odd code around ginScanToDelete
Previous Message Xuneng Zhou 2026-03-10 09:19:39 Re: Odd code around ginScanToDelete