| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Ignat Remizov <ignat980(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix typo in psql \copy command documentation |
| Date: | 2025-12-06 19:42:14 |
| Message-ID: | CALdSSPhQH9dYvo1EcndNddUsOdsSOhRe4Uzh8EL_2nOT9vhTOA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 6 Dec 2025, 20:39 Ignat Remizov, <ignat980(at)gmail(dot)com> wrote:
> Hi Postgres hackers,
>
> Small comment typo fix: pstdout was listed twice; first should be pstdin.
> Patch inline.
>
> Kind regards,
> Ignat Remizov
>
> From a4ae3eb6abd1189a2710b09efd567e46ed9b1f83 Mon Sep 17 00:00:00 2001
> From: Ignat Remizov <ignat980(at)gmail(dot)com>
> Date: Sat, 6 Dec 2025 17:30:20 +0200
> Subject: [PATCH] Fix typo in psql \copy command documentation
>
> The comment documenting \copy command syntax incorrectly listed
> "pstdout" twice. The first instance should be "pstdin" to correctly
> reflect that the command accepts both pstdin and pstdout as valid
> filename options.
>
> This is a documentation-only change with no functional impact.
> ---
> src/bin/psql/copy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/psql/copy.c b/src/bin/psql/copy.c
> index 92c955b637a..04553c3a33f 100644
> --- a/src/bin/psql/copy.c
> +++ b/src/bin/psql/copy.c
> @@ -33,7 +33,7 @@
> * \copy ( query stmt ) to filename [options]
> *
> * where 'filename' can be one of the following:
> - * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdout |
> pstdout
> + * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdin | pstdout
> * and 'query' can be one of the following:
> * SELECT | UPDATE | INSERT | DELETE
> *
> --
> 2.43.0
>
Hi!
Your patch WFM.
But i want to remind you can people usually send patches here as file.
Well, for single liners including patch directly in message body is OK, but
in nearby thread you did same for relatively big change so...
My recipe is coding locally, then git commit and git format-patch -v
whatever-version -1 sha-of-commit
Sorry for being nitpicky
LGTM
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-12-06 20:04:20 | Re: Moving _bt_readpage and _bt_checkkeys into a new .c file |
| Previous Message | Tom Lane | 2025-12-06 19:00:48 | Re: Making jsonb_agg() faster |