| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Sugamoto Shinya <shinya34892(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add error hints for invalid COPY options |
| Date: | 2025-12-04 07:35:43 |
| Message-ID: | CALdSSPgy8P3AgZyQ+TEp9ErpyXtu-rp2rg3JFQcTeKOCXGr+ZA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 4 Dec 2025 at 03:56, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> The proposed patch requires us to create one function per option. I'm
> concerned that it could cause bloating functions and be overkill just
> to save changing a separate list. I would suggest starting with
> putting a validation check for options at the top of foreach() loop.
> When adding a new COPY option in the future, it wouldn't work if we
> miss either changing the valid-options list or handling the option,
> which seems a good prevention.
>
Yep, Im +1 on that. "bloating functions" - that's precise wording, I
did not know how to explain the same concern.
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-12-04 07:42:16 | Re: Improve error reporting in 027_stream_regress test |
| Previous Message | Michael Paquier | 2025-12-04 07:28:00 | Re: Re: Extended Statistics set/restore/clear functions. |